Skip to content

Fix get top billionaires BROKEN file #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 18, 2023
Merged

Fix get top billionaires BROKEN file #8970

merged 8 commits into from
Aug 18, 2023
+21 −7

Conversation

CaedenPH
Copy link
Contributor

@CaedenPH CaedenPH commented Aug 16, 2023 •
edited
Loading

Describe your change:

Fixes a get_top_billionaires and unmarks it as disabled

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@CaedenPH CaedenPH requested a review from cclauss as a code owner August 16, 2023 15:43
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 16, 2023
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 16, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Aug 16, 2023
@algorithms-keeper algorithms-keeper bot mentioned this pull request Aug 16, 2023
Closed
14 tasks
@CaedenPH
Copy link
Contributor Author

@cclauss This pr also fixes a broken file. The problem was that the unix timestamps were negative (if the billionaire is older than 53) which python causes python datetime to error (overflow error)

@CaedenPH CaedenPH requested a review from tianyizheng02 August 18, 2023 08:34
tianyizheng02
tianyizheng02 requested changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the doctests so that we don't have to update the ages every year? (see previous comment)

@CaedenPH CaedenPH requested a review from tianyizheng02 August 18, 2023 11:48
@algorithms-keeper algorithms-keeper bot mentioned this pull request Aug 18, 2023
Merged
14 tasks
tianyizheng02
tianyizheng02 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally, looks like it works 👍

@tianyizheng02 tianyizheng02 merged commit 5f7819e into TheAlgorithms:master Aug 18, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 18, 2023
@CaedenPH CaedenPH deleted the fix-get-top-billionaires branch August 18, 2023 12:17
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @sedatguzelsemme
Fix get top billionaires BROKEN file (TheAlgorithms#8970)
5925b3b 
* updating DIRECTORY.md

* fix(get-top-billionaires): Handle timestamp before epoch

* updating DIRECTORY.md

* revert(pyproject): Re-implement ignore lru_cache

* fix(age): Update age to current year

* fix(doctest): Make years since dynamic

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaedenPH @tianyizheng02